-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix professors for sections not being scraped #244
Merged
Merged
+11,702
−8,100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Dockerfile to use Yarn Berry and Corepack, changing the build commands to reflect this change.
Lucas-Dunker
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merge and rescrape asap! Just remove that console.log lol
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Scrapes the professors for a section. Because the Banner API removed this field from the search results when not authenticated through Northeastern SSO, this has to be acquired via a separate request to the section professor details page.
Tickets
Feature List
Notes
This is kinda thrown together and the implementation very much can be improved. For now, it gets the job done but the scraper needs some love... I think there is code in there that is tested but never used?
Reviewers
Primary:
@ananyaspatil
Secondary:
@nickpfeiffer05 @Anzhuo-W @cherman23
UPDATE: As troubleshooting the OpenSSL error, the Yarn Berry PR #241 was merged into this PR. For documentation, the PR comment has been reproduced below.
Purpose
Migrates off of the end-of-life Yarn Classic to the actively maintained Yarn Berry version. In general, it is a drop in replacement, using the Node experimental Corepack as the preferred installation / management tool (the irony of managing a package manager).
Tickets
Closes #225, Closes #232
Feature List
node_modules
compatibility mode.Notes
I will open a PR on searchneu soon to ensure that there is a version locked in because Corepack likes to add itself otherwise.